Use typescript.d.ts in APISample tests #51061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we pull in the types for typescript in these tests works by including typescriptServices.d.ts into the project, which declares a global namespace, which then is reexported as a faked typescript package.
This reexport is already what the current typescript.d.ts does, so use that instead. This will allow us to remove
typescriptServices.d.ts
in the future.This has been pulled out of #51026 as it's a change that can be made without removing typescriptServices.